Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added typescript types to fluidTextArea and FluidTextAreaSkeleton #17355

Conversation

riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Sep 6, 2024

Closes #17354

Added typescript types to FluidTextArea and FluidTextAreaSkeleton and converted index.js to index.tsx

Changelog

Changed

  • Added typescript types to FluidTextArea and FluidTextAreaSkeleton and converted index.js to index.tsx

Testing / Reviewing

Everything should work as intended for fluiDtextArea

@riddhybansal riddhybansal requested a review from a team as a code owner September 6, 2024 07:50
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 97ee2a6
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66dab44ffdf37800082efecd
😎 Deploy Preview https://deploy-preview-17355--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 97ee2a6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66dab44f317869000888e5ab
😎 Deploy Preview https://deploy-preview-17355--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 229678f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e17d000749c4000886d717
😎 Deploy Preview https://deploy-preview-17355--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 229678f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e17d006309d500088a8338
😎 Deploy Preview https://deploy-preview-17355--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guidari guidari added this pull request to the merge queue Sep 11, 2024
Merged via the queue into carbon-design-system:main with commit 581aee8 Sep 11, 2024
23 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Types for FluidTextArea, FluidTextAreaSkeleton
4 participants