fix: Fixed aria-current in BreadcrumbItem
#17311
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
The current breadcrumb now gets the focus ring via keyboard navigation and VO is announcing the status 🔥
One questions :
via keyboard navigation: the last/current breadcrumb gets focus ring, and underline.
on mouse hover : underline and cursor pointer is missing on the last/current breadcrumb
Wanted to confirm the expected behaviour, It seems alright to me
Screen.Recording.2024-09-04.at.09.30.16.mov
I'm not sure about this one. I guess this is right.
This one is correct, if the breadcrumb item has |
|
Should the current page have the hover state, this feels odd without the cursor change. 🤔 |
annawen1
changed the title
BreadcrumbItemBreadcrumbItem
|
@carbon-design-system/design Can anyone help on this one? |
As per the Interaction guidelines, the current page should receive no interaction, so no hover, no colour change. 
It technically shouldn't even receive tab stop as per Accessibility guidelines |
* fix: fixed aria-current * fix: fixed test to match the new stories * fix: fixed changes in storybook --------- Co-authored-by: Nikhil Tomar <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ac90647
|
Hey there! v11.66.0 was just released that references this issue/PR. |
Closes #16749
Added prop
isCurrentto the logic and also added anhrefto make the breadcrumb tabbable.Testing / Reviewing