-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inline-loading): update text size #17259
Merged
kennylam
merged 4 commits into
carbon-design-system:main
from
emyarod:17134-fix/inline-loading-text-size
Aug 31, 2024
Merged
fix(inline-loading): update text size #17259
kennylam
merged 4 commits into
carbon-design-system:main
from
emyarod:17134-fix/inline-loading-text-size
Aug 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Aug 23, 2024
alisonjoseph
approved these changes
Aug 23, 2024
thyhmdo
approved these changes
Aug 26, 2024
kennylam
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: visual review 🔍
labels
Aug 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 31, 2024
Merged
via the queue into
carbon-design-system:main
with commit Aug 31, 2024
f43b460
23 checks passed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17134
This PR updates the InlineLoading text size to match the spec
Changelog
Changed
Testing / Reviewing
view the InlineLoading story and confirm the correct text size is displayed