fix: add new props to feature flag props #17239
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const parentScope = useContext(FeatureFlagContext); | ||
| const [prevParentScope, setPrevParentScope] = useState(parentScope); | ||
|
|
||
| const combinedFlags = { | ||
| 'enable-use-controlled-state-with-value': enableUseControlledStateWithValue, |
There was a problem hiding this comment.
It doesn't look like this is actually used anywhere anymore, is that what you see as well? The useControlledStateWithValue in here doesn't seem to be used anywhere either
carbon/packages/react/src/internal/FeatureFlags.js
Lines 49 to 51 in 36685a0
If so we should remove this one
| enableUseControlledStateWithValue, | ||
| enableV12TileDefaultIcons, | ||
| enableV12TileRadioIcons, | ||
| enableV12Overflowmenu, | ||
| enableTreeviewControllable, | ||
| enableExperimentalFocusWrapWithoutSentinels, |
There was a problem hiding this comment.
Do these need the same defaults as what's defined in the root flag definition?
carbon/packages/feature-flags/feature-flags.yml
Lines 25 to 52 in b9abee7
|
Closing in favor of #17266, I moved my review comments to there as well |
Closes #17238
Add new boolean props for all existing feature flags
Update FeatureFlag internals to map the boolean props back into an object form to be used in the scope of FeatureFlagContext
Changelog
New
-Update FeatureFlag internals to map the boolean props back into an object form to be used in the scope of FeatureFlagContext
Testing / Reviewing