Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added autoAlign in copyButton, codeSnippet and iconButton #17138

Conversation

preetibansalui
Copy link
Contributor

@preetibansalui preetibansalui commented Aug 12, 2024

Closes #16709

Added autoAlign prop in CopyButton, CodeSnippet and IconButton components

@preetibansalui preetibansalui requested a review from a team as a code owner August 12, 2024 06:30
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 16bcc2f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66dfe33cc8b38d000862feb7
😎 Deploy Preview https://deploy-preview-17138--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 16bcc2f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66dfe33c7cf96f0008af0d2e
😎 Deploy Preview https://deploy-preview-17138--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I think we should remove the storybook stories before merging. They're extraneous, and the autoAlign prop is still documented in the prop api tables

@tay1orjones tay1orjones added this pull request to the merge queue Sep 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Sep 10, 2024
Merged via the queue into carbon-design-system:main with commit 68799ee Sep 10, 2024
23 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add autoAlign to CodeSnippet / CopyButton
4 participants