Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FluidListbox): fix issues with ai-enabled fluid listbox components #16170

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

tw15egan
Copy link
Collaborator

Closes #16168

Fixes discrepancies between the Select and the Listbox components. It also fixes an issue with the border on Textarea not being removed when invalid.

Changelog

Changed

  • Added some specificity so that fluid positioning is correct

Removed

  • ::before divider for invalid icon when in fluid because those invalid icons are not next to the slug

Testing / Reviewing

Ensure the invalid and warning icons are correctly positioned, and the spacing between the Select and other Listbox component dividers match.

@tw15egan tw15egan requested a review from a team as a code owner April 10, 2024 18:01
@tw15egan tw15egan requested review from tay1orjones and guidari April 10, 2024 18:01
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ee56a66
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6616e5b932f1a700082eb9aa
😎 Deploy Preview https://deploy-preview-16170--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

Do you think it makes sense to VRT these stories to avoid regressions like this?

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing I noticed is that the Dropdown components have a greater width for some reason? Kind of ddd because when !invalid they're all perfectly aligned

image

@tw15egan
Copy link
Collaborator Author

@tay1orjones The main issues were only viewable when the inputs were invalid; I don't know if we are using VRT tests for invalid states anywhere, are we? Regarding the invalid dropdown, I believe that when building it, it had to use an outer outline for some reason, not an inset outline. It could be added to a future sprint to take another look and see if we can improve upon it.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@guidari guidari added this pull request to the merge queue Apr 16, 2024
Merged via the queue into carbon-design-system:main with commit 83082ca Apr 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Visual bugs with fluid components with AI Slug
3 participants