Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): update Modal styles to phase 3 spec #16029

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

tw15egan
Copy link
Collaborator

Closes #15955

Updates Modal and ComposedModal to the phase 3 spec

Changelog

Changed

  • Renders the sm Slug by default inside Modal
  • Adjusted positioning based on new size

Removed

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3fda6bb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65fc5b1443d99200084fc78d
😎 Deploy Preview https://deploy-preview-16029--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

@aagonzales this one's ready for you to review

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modal itself looks good but I noticed there were some bugs in the slug coming through. Not sure if that's related to this PR or not so I'll go ahead and approve.

image

@tw15egan tw15egan added this pull request to the merge queue Mar 28, 2024
@tw15egan
Copy link
Collaborator Author

@aagonzales, I think the button underneath may affect the filter blur on the action bar 😬

Merged via the queue into carbon-design-system:main with commit 4e00640 Mar 28, 2024
20 checks passed
@tw15egan tw15egan deleted the modal-phase3-updates branch March 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AI] Phase 3: update AI modal with new visuals
4 participants