-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AISkeleton): export ai skeleton, update dark theme tokens #15991
Merged
tw15egan
merged 5 commits into
carbon-design-system:main
from
tw15egan:export-ai-skeleton
Mar 19, 2024
Merged
fix(AISkeleton): export ai skeleton, update dark theme tokens #15991
tw15egan
merged 5 commits into
carbon-design-system:main
from
tw15egan:export-ai-skeleton
Mar 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
changed the title
Export ai skeleton
fix(AISkeleton): export ai skeleton, update dark theme tokens
Mar 18, 2024
tay1orjones
approved these changes
Mar 18, 2024
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aagonzales
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
alisonjoseph
approved these changes
Mar 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 19, 2024
Merged
via the queue into
carbon-design-system:main
with commit Mar 19, 2024
b60cb78
20 checks passed
tw15egan
added a commit
to tw15egan/carbon
that referenced
this pull request
Mar 19, 2024
…-design-system#15991) * fix(AISkeleton): export AI Skeleton components * fix(AISkeleton): update tokens in dark themes * test(AISkeleton): update snapshots * chore(eslint): fix linting error
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…-design-system#15991) * fix(AISkeleton): export AI Skeleton components * fix(AISkeleton): update tokens in dark themes * test(AISkeleton): update snapshots * chore(eslint): fix linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the
AISkeleton
components were not exported properly. Also makes small tweaks to theAISkeleton
dark theme tokensChangelog
Changed
AISkeleton
components toindex.ts
$ai-skeleton-background
and$ai-skeleton-element-background
tokens ing90
andg100
themesTesting / Reviewing
Ensure
AISkeleton
components are successfully exported. Ensure new tokens look correct ing90
andg100
themes