Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AISkeleton): export ai skeleton, update dark theme tokens #15991

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

tw15egan
Copy link
Collaborator

Fixes an issue where the AISkeleton components were not exported properly. Also makes small tweaks to the AISkeleton dark theme tokens

Changelog

Changed

  • Added AISkeleton components to index.ts
  • Updated $ai-skeleton-background and $ai-skeleton-element-background tokens in g90 and g100 themes

Testing / Reviewing

Ensure AISkeleton components are successfully exported. Ensure new tokens look correct in g90 and g100 themes

@tw15egan tw15egan requested a review from a team as a code owner March 18, 2024 13:29
@tw15egan tw15egan changed the title Export ai skeleton fix(AISkeleton): export ai skeleton, update dark theme tokens Mar 18, 2024
@tw15egan tw15egan requested a review from aagonzales March 18, 2024 13:30
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 3301f37
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f9a8e5bf253e00086e5ba6
😎 Deploy Preview https://deploy-preview-15991--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan tw15egan requested a review from a team as a code owner March 18, 2024 13:56
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alisonjoseph alisonjoseph added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@tw15egan tw15egan added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@tw15egan tw15egan added this pull request to the merge queue Mar 19, 2024
Merged via the queue into carbon-design-system:main with commit b60cb78 Mar 19, 2024
20 checks passed
@tw15egan tw15egan deleted the export-ai-skeleton branch March 19, 2024 15:56
tw15egan added a commit to tw15egan/carbon that referenced this pull request Mar 19, 2024
…-design-system#15991)

* fix(AISkeleton): export AI Skeleton components

* fix(AISkeleton): update tokens in dark themes

* test(AISkeleton): update snapshots

* chore(eslint): fix linting error
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
…-design-system#15991)

* fix(AISkeleton): export AI Skeleton components

* fix(AISkeleton): update tokens in dark themes

* test(AISkeleton): update snapshots

* chore(eslint): fix linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants