-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ChatButton): add,utilize chat button tokens for quick action button #15923
Merged
tw15egan
merged 4 commits into
carbon-design-system:main
from
tw15egan:chat-button-tokens
Mar 11, 2024
Merged
feat(ChatButton): add,utilize chat button tokens for quick action button #15923
tw15egan
merged 4 commits into
carbon-design-system:main
from
tw15egan:chat-button-tokens
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Mar 8, 2024
aagonzales
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tw15egan
force-pushed
the
chat-button-tokens
branch
from
March 8, 2024 21:17
f697621
to
c760c5d
Compare
@aagonzales fixed 👍 |
aagonzales
approved these changes
Mar 8, 2024
alisonjoseph
approved these changes
Mar 11, 2024
Merged
via the queue into
carbon-design-system:main
with commit Mar 11, 2024
23c0998
20 checks passed
Hey there! v11.53.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15920
Adds in 6 new
ChatButton
specific tokens, and styles to apply these tokensNote: these will only style the
isQuickAction
variant. Normal button tokens can be used to style the differentkind
s ofChatButton
.Changelog
New
$chat-button
$chat-button-hover
$chat-button-text-hover
$chat-button-selected
$chat-button-active
$chat-button-text-selected
Changed
ChatButton
specific tokensTesting / Reviewing
To test, replace the normal styles import in
./storybook/styles.scss
with the following:and ensure that only the quick action
ChatButton
variant has its token values changed. Ensure all states are styled properly