fix: remove title from tag component #15886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
A long time ago this was added so that if a user has a tag with lots of words and they set text-overflow:ellipsis on it, the title would show on hover to reveal the full text.
The design guidance now states that tags should be one or two words at most, so I think this isn't so much a concern anymore. Additionally I think using a Tooltip in that scenario would be preferred anyway?
All this to say I think the historical reason why this was initially added no longer applies. Let me know if I'm wrong!
|
For context, here's the PR @tw15egan do you have any thoughts or recall any specifics beyond whats in the review there? |
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Mar 6, 2024
a25947d
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15885
this address an accessibility issue with voiceover where tag's where being described as "groups". the underlying problem appears to be usage of a title attribute in the tag
span. double checking the title documentation in MDN i don't believe a title is necessary here and removing it alleviates the voiceover problem.i was able to verify this change by running voiceover locally and verifying that this change wasn't a new violation in the equal access checker.