Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): fix ai gradient issue in safari #15842

Merged

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 28, 2024

Closes #15841

Fixes an issue with the gradient background in DataTable

Changelog

New

  • Added background-attachment: fixed; to hover, selected styles

Testing / Reviewing

View unstable__Slug --> DataTable with a slug row in Safari and ensure gradients look correct.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b080744
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65df67880e32000007d9a737
😎 Deploy Preview https://deploy-preview-15842--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good!

@tw15egan tw15egan added this pull request to the merge queue Mar 1, 2024
Merged via the queue into carbon-design-system:main with commit 77fdcf8 Mar 1, 2024
20 checks passed
@tw15egan tw15egan deleted the ai-gradient-data-table-fix branch March 1, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with AI gradient on hover/selected DataTable row in Safari
4 participants