Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add tsconfig note to @carbon/react README.md #15679

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

ggdawson
Copy link
Contributor

@ggdawson ggdawson commented Feb 1, 2024

Closes #15678

Adds a note to the @carbon/react README.md about how to get the TS compiler working.

Changelog

New

  • n/a

Changed

  • @carbon/react/README.md

Removed

  • n/a

Testing / Reviewing

Have tested the suggestion in my own projects, and it appears to be working.

@ggdawson ggdawson requested a review from a team as a code owner February 1, 2024 23:34
Copy link
Contributor

github-actions bot commented Feb 1, 2024

DCO Assistant Lite bot All contributors have signed the DCO.

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 64aea67
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ca853a78aa6a0008267cd4
😎 Deploy Preview https://deploy-preview-15679--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ggdawson
Copy link
Contributor Author

ggdawson commented Feb 1, 2024

I have read the DCO document and I hereby sign the DCO.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggdawson ggdawson force-pushed the carbon-react-ts branch 3 times, most recently from b6e328e to d3c3153 Compare February 12, 2024 20:51
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tay1orjones tay1orjones added this pull request to the merge queue Feb 15, 2024
Merged via the queue into carbon-design-system:main with commit a0fe7a9 Feb 15, 2024
21 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.51.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Revise @carbon/react README to include note about TypeScript usage
3 participants