fix(icons-react): fix exports in individual icon TypeScript declarations #15032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metonym FYI. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
metonym
reviewed
Oct 26, 2023
| m.name + | ||
| ': CarbonIconType;\n'; | ||
| `const ${m.name}: CarbonIconType;\n` + | ||
| `export default ${m.name}\n`; |
There was a problem hiding this comment.
FYI, I see this locally when copying/pasting this change to my local environment:
There was a problem hiding this comment.
@metonym thanks for spotting! I added the missing declare keyword and it seems to be better now. Please confirm if this also helps in your setup.
metonym
approved these changes
Oct 30, 2023
| m.name + | ||
| ': CarbonIconType;\n'; | ||
| `const ${m.name}: CarbonIconType;\n` + | ||
| `export default ${m.name}\n`; |
tay1orjones
approved these changes
Nov 1, 2023
alisonjoseph
approved these changes
Nov 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…ons (#15032) * fix(icons-react): fix exports in individual icon TypeScript declarations * fix(icon-build-helpers): add missing declare keyword in TS builder --------- Co-authored-by: TJ Egan <[email protected]>
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 1, 2023
…ons (carbon-design-system#15032) * fix(icons-react): fix exports in individual icon TypeScript declarations * fix(icon-build-helpers): add missing declare keyword in TS builder --------- Co-authored-by: TJ Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem raised in #14714 (comment): improper typescript type exports in individual icons TypeScript declaration file (.d.ts).
Changelog
Changed
Testing / Reviewing
Tested in TypeScript project by linking the patched Carbon version. Can import individual icon using default import.