Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useLayoutEffect SSR warning fix #15025

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

k-rajat19
Copy link
Contributor

Closes #14936

replaced useLayoutEffect with internal useIsomorphicEffect
For more context:
https://gist.github.com/gaearon/e7d97cdf38a2907924ea12e4ebdf3c85

@k-rajat19 k-rajat19 requested a review from a team as a code owner October 25, 2023 20:10
@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 080629d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/653a835282839b000890b3a7
😎 Deploy Preview https://deploy-preview-15025--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 25, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 080629d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/653a835258503b0008e84c45
😎 Deploy Preview https://deploy-preview-15025--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

@andreancardona andreancardona added this pull request to the merge queue Oct 26, 2023
Merged via the queue into carbon-design-system:main with commit 7d2cc28 Oct 26, 2023
16 checks passed
@k-rajat19 k-rajat19 deleted the uselayout-ssr branch October 26, 2023 17:33
@carbon-automation
Copy link
Contributor

Hey there! v11.41.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useLayoutEffect warnings from DataTable in SSR usage
3 participants