feat(Slug): implement AI Slug #14998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@aagonzales pushed this up to get some feedback, spacing is definitely off on inline variants but are easy fixes. Wanted to get it up ASAP so we can iterate |
aagonzales
requested changes
Oct 25, 2023
|
A couple more tweaks for the inline with text: @tw15egan
|
tay1orjones
approved these changes
Oct 25, 2023
andreancardona
approved these changes
Oct 25, 2023
aagonzales
requested changes
Oct 25, 2023
There was a problem hiding this comment.
woo-hoo! TJ these look awesome. Only two small things and the second isn't even that important.
- Its inline slug again, the hollow dot on the two smaller sizes are misaligned by 1px. Can you move the hollow dot over 1px to the left.
- Ok this one probably doesn't matter too much but if its easy would we adjust the text colors of the content inside the example callout (very low priority for Thursday release)
Other than that I its good for the first release tomorrow 🎉
|
@aagonzales updated 👍🏻 |
aagonzales
approved these changes
Oct 26, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 26, 2023
b1c721c
14 checks passed
|
Hey there! v11.41.0 was just released that references this issue/PR. |
Tomahaawk
pushed a commit
to Tomahaawk/carbon
that referenced
this pull request
Oct 31, 2023
* feat(Slug): scaffold out AI Slug component * feat(slug): add gradient tokens to themes, hover styles * feat(slug): add focus styles, cleanup storybook * fix(Theme): adjust small slug hover tokens * feat(Slug): add hollow slug * feat(Slug): initial inline styles * chore(snapshot): update snapshots * feat(Slug): add inline styles * fix(Slug): refactor inline variant * style(Slug): tweak inline styles * style(Slug): add hover styles to inline variant * style(Slug): add initial callout styles * style(Slug): tokenize gradients * style(Slug): adjust padding * chore: udpate snapshots * style(Slug): adjust padding with hollow dot, fix text colors * fix(Slug): fix hover styles when focused * refactor(Slug): remove ai from prefix --------- Co-authored-by: Andrea N. Cardona <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14947
Adds in the
unstable__slugcomponentChangelog
New
unstable__Slugcomponent withdefault,hollow, andinlinevariantsTesting / Reviewing
Go to
unstable__Slugunder the experimental section at the bottom and verify against the spec