Feat: Forwarding Ref in TableExpandRow component
#14950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-rajat19
commented
Oct 19, 2023
|
|
||
| TableExpandRow.propTypes = { | ||
| /** | ||
| * Space separated list of one or more ID values referencing the TableExpandedRow(s) being controlled by the TableExpandRow | ||
| * TODO: make this required in v12 | ||
| */ | ||
| /**@ts-ignore*/ |
There was a problem hiding this comment.
"@types/react": "~17.0.2" breaking prop-types
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Oct 26, 2023
tw15egan
approved these changes
Oct 30, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
tay1orjones
removed this pull request from the merge queue due to the queue being cleared
Merged
via the queue into
carbon-design-system:main
with commit Oct 31, 2023
cb2e75a
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9443