test(e2e): add proper tags to avt tests #14915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Oct 16, 2023
andreancardona
approved these changes
Oct 17, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
…595-partial-avt-tags
|
Yeah I just resolved the conflicts and retested locally and everything passes fine. I think CI should pass 🤞 |
|
@tay1orjones a few merge conflicts to resolve here |
|
Conflicts resolved. I also added a change to shard the AVT tests to prevent the timeout failures we've been seeing due to the increased load of |
…595-partial-avt-tags
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
* test(e2e): add proper tags to avt tests * ci(avt): shard avt tests * fix: typo * test(config): increase playwright expect timeout * test(playwright): increase timeout config * test(progressindicator): update to use proper tags * test(progressindicator): correct focus order --------- Co-authored-by: Andrea N. Cardona <[email protected]> Co-authored-by: Alison Joseph <[email protected]> Co-authored-by: TJ Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14595
Related to #14913
This updates test files to use the proper avt tags within test titles.
Changelog
New
*-test.avt.e2e.jstest files for components that didn't have their avt tests separated out into this separate file yetChanged
Testing / Reviewing