feat(component): replaced SideNavIcon.js -> SideNavIcon.tsx component #14889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Oct 18, 2023
|
Thank you for the contribution @Nirajsah !! |
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
I'm glad I could help 😊 |
Merged
via the queue into
carbon-design-system:main
with commit Oct 18, 2023
5b203db
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13601
I successfully replaced the
SideNavIcon.jscomponent withSideNavIcon.tsxalong with the corresponding type definitions. I have also executed tests, and they ran without any issues. Although there was an issue resulting in a "build failed" status, I addressed the situation by making thesmallprop optional in theSideNavIconcomponent. To ensure its functionality even when not provided, a default value offalseis assigned.Changelog
New
Changed
SideNavIcon.jstoSideNavIcon.tsxsmallprop as optional in SideNavIconProps.Removed
Testing / Reviewing
SideNavIcon.tsxfile and its associated TypeScript types for correctness and completeness.Please provide feedback and verify the changes. My last PR failed because of the issue i mentioned above, it's resolved now.