Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contentswitcher avt tests #14735

Merged

Conversation

andreancardona
Copy link
Contributor

Closes #14729

Added keyboard navigation to ContentSwitcher component.

Changelog

New

  • Added new file e2e/components/ContentSwitcher/ContentSwitcher-test.avt.e2e.js

Testing / Reviewing

  • Ensure the test pass.
  • Ensure that the expected navigation is covered.

@andreancardona andreancardona requested a review from a team as a code owner September 29, 2023 13:53
@andreancardona andreancardona changed the title feat: contentswitcher avttests feat: contentswitcher avt tests Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b5ed621
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6520505c4a095e000850e626
😎 Deploy Preview https://deploy-preview-14735--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b5ed621
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6520505c4c358e00080c8145
😎 Deploy Preview https://deploy-preview-14735--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@github-actions github-actions bot added this pull request to the merge queue Oct 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 17, 2023
@guidari guidari added this pull request to the merge queue Oct 18, 2023
Merged via the queue into carbon-design-system:main with commit a0cf45d Oct 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Nav AVT test for ContentSwticher
3 participants