Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(data-table): hide toolbar content from screenreader when hidden #14649

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Sep 13, 2023

Closes #14264

Changelog

  • update dynamic DataTable story to correctly set aria-hidden on toolbar when visually hidden

Testing / Reviewing

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1cdefe3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6501eda3259718000815fd8b
😎 Deploy Preview https://deploy-preview-14649--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 1cdefe3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6501eda3ec1fbe000896c669
😎 Deploy Preview https://deploy-preview-14649--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one, I thought I got em all.

@tay1orjones tay1orjones added this pull request to the merge queue Sep 14, 2023
Merged via the queue into carbon-design-system:main with commit e4734d9 Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: DataTable [dynamic] - search field announced when visually hidden with SR
3 participants