Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(IconSkeleton): convert to TypeScript #14636

Merged
merged 2 commits into from
Sep 12, 2023
Merged

refactor(IconSkeleton): convert to TypeScript #14636

merged 2 commits into from
Sep 12, 2023

Conversation

sjbeatle
Copy link
Contributor

Closes #13558

Adds TypeScript types to IconSkeleton component.

Changelog

Changed

  • Added TypeScript types to IconSkeleton component

Testing / Reviewing

In a TypeScript environment, you should be able to import and reference the IconSkeleton component and its typings.

@sjbeatle sjbeatle requested a review from a team as a code owner September 11, 2023 20:51
@netlify
Copy link

netlify bot commented Sep 11, 2023 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a6f5916
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/64ffac1081419e0008266654
😎 Deploy Preview https://deploy-preview-14636--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 11, 2023 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a6f5916
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ffac10003cf20007a1f1b9
😎 Deploy Preview https://deploy-preview-14636--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andreancardona
andreancardona approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thank you for the contribution!

@github-actions github-actions bot enabled auto-merge September 12, 2023 00:09
@github-actions github-actions bot added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2023
@tw15egan tw15egan added this pull request to the merge queue Sep 12, 2023
Merged via the queue into carbon-design-system:main with commit 391c8e4 Sep 12, 2023
misiekhardcore pushed a commit to misiekhardcore/carbon that referenced this pull request Sep 18, 2023
@sjbeatle @andreancardona @misiekhardcore
refactor(IconSkeleton): convert to TypeScript (carbon-design-system#1…
75be250 
…4636)

Co-authored-by: Andrea N. Cardona <[email protected]>
@sjbeatle sjbeatle deleted the typescript-iconskeleton branch September 20, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to IconSkeleton
4 participants
@sjbeatle @alisonjoseph @andreancardona @tw15egan