Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(avt): include playwright test report json in @carbon/react #14538

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

tay1orjones
Copy link
Member

First part of #14480

This modifies the playwright config to output a duplicate json report file that will be included in the build output of @carbon/react.

This file will be used within carbon-website to generate automated accessibility test status tables for each component.

Changelog

New

  • Add docs establishing a naming convention for avt test names and tags

Changed

  • Update release workflow to run avt tests and produce the json file
  • Update @carbon/react package.json to include the new file as part of the published package
  • Update playwright config to output the report json within packages/react/.playwright
  • Refactor accordion avt tests to be properly named using the newly documented tag naming convention

Testing / Reviewing

  • There's nothing really to test here, other than pulling down and running yarn playwright test and ensure the INTERNAL_AVT_REPORT_DO_NOT_USE.json file is output and in the proper location.

@tay1orjones tay1orjones requested a review from a team as a code owner August 29, 2023 18:00
@tay1orjones tay1orjones changed the title test(avt): include playwright test report json in @carbon/react test(avt): include playwright test report json in @carbon/react Aug 29, 2023
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 8b62f91
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64ee399e77db510008b76569
😎 Deploy Preview https://deploy-preview-14538--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8b62f91
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ee399ec746b30008211f09
😎 Deploy Preview https://deploy-preview-14538--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@guidari guidari added this pull request to the merge queue Aug 31, 2023
Merged via the queue into carbon-design-system:main with commit 78472c6 Aug 31, 2023
15 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.37.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants