Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(TreeView): add @avt tests #14512

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

tw15egan
Copy link
Collaborator

Closes #14417

Adds in AVT tests for TreeView

Changelog

New

  • TreeView-test.avt.e2e.js

Changed

  • Moved AVT tests to .avt file
  • Updated the TreeView story to match the content that is on the website. This gives each node a semantic name, which makes testing easier.

Testing / Reviewing

Ensure all tests pass and that all keyboard interactions are covered

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7b10adb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64ede6d807948400080b92aa
😎 Deploy Preview https://deploy-preview-14512--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7b10adb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64ede6d8d5aa3f0008128a5d
😎 Deploy Preview https://deploy-preview-14512--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@github-actions github-actions bot added this pull request to the merge queue Aug 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 28, 2023
@tay1orjones tay1orjones added this pull request to the merge queue Aug 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2023
@guidari guidari enabled auto-merge August 29, 2023 12:38
@guidari guidari added this pull request to the merge queue Aug 29, 2023
Merged via the queue into carbon-design-system:main with commit b23820c Aug 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for unstable_TreeView states: Closed state
3 participants