refactor(SkeletonPlaceholder): convert SkeletonPlaceholder to TypeScript #14501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewandom
force-pushed
the
typescript-skeletonplaceholder
branch
from
b7aa577
to
6999cec
Compare
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Aug 23, 2023
alisonjoseph
approved these changes
Aug 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
tay1orjones
approved these changes
Aug 24, 2023
Merged
via the queue into
carbon-design-system:main
with commit Aug 24, 2023
493ac04
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13575
Adds TypeScript types to SkeletonPlaceholder component.
Changelog
Changed
Testing / Reviewing
The SkeletonPlaceholder component imports for the storybook should be valid and rendering. In a TypeScript environment, you should be able to import and reference the SkeletonPlaceholder component and its typings.