Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionableNotification): fix hover token #14494

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #14448

fixes an issue where inline ActionableNotification button color was not changing on hover when low contrast was enabled

Changelog

Changed

  • Adjusted token so the correct value was implemented

Testing / Reviewing

Go to ActionableNotification and enable lowContrast and inline. Ensure the button has a white background on hover

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 58f8b07
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e51ac1b0f77a0008e07826
😎 Deploy Preview https://deploy-preview-14494--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 58f8b07
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e51ac19dfce100086650a6
😎 Deploy Preview https://deploy-preview-14494--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added this pull request to the merge queue Aug 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 23, 2023
@tw15egan tw15egan added this pull request to the merge queue Aug 23, 2023
Merged via the queue into carbon-design-system:main with commit 1c70f5b Aug 23, 2023
18 checks passed
@tw15egan tw15egan deleted the notification-token-fix branch August 23, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Actionable notification: hover color bug in light themes
3 participants