-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(numberinput): use native methods for stepping the value up/down #14463
fix(numberinput): use native methods for stepping the value up/down #14463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 nice!
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀
Looks like we just need to remove the LegacyRef
prop, so the lint is good to go!
@tay1orjones this is awesome 🙌🏻 |
This will also close #12897 |
c678397
Closes #6684
Closes #12897
Changelog
Changed
stepUp()
andstepDown()
methods to step the value up and downTesting / Reviewing
0.01
+
stepper many times0.01
50.999999998