fix: slider to range step values #14460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Aug 18, 2023
alisonjoseph
approved these changes
Aug 18, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Aug 21, 2023
1aab3b5
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14455
Javascript floating point maths is a bit problematic.
0.3 + 0.3 + 0.3 evaluates to 0.89999999999'
The range control does not normally have a problem with this, ensuring the nearest fixed length value is used.
While this could be fixed by replicating the math inside the standard input control, the simplest solution is to set the value of a range control and read it back. This PR does just that.
Changelog
Changed
Testing / Reviewing
Slidercomponent.Stepto 0.3.The result should be 0.9 but is 0.8999999' due to JS floating point math.
Applying this PR we can see the value is 0.9.