Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataTable): backport checkbox selection a11y fix to v10 #14438

Merged
merged 2 commits into from
Aug 16, 2023
Merged

fix(DataTable): backport checkbox selection a11y fix to v10 #14438

merged 2 commits into from
Aug 16, 2023

Conversation

kenneth-nguyen1
Copy link

Closes #14002
Refs #14206

Backports a11y fix for the InlineCheckbox component to v10

This fixes the AVT violation The ARIA attributes "aria-label" are not valid for the element <label> with ARIA role "none" seen on the DataTable Selection variant in Carbon v10.

Changelog

Changed

  • Copied changes over from v11 regarding the referenced issue
  • Updated snapshot tests for unit tests to pass with new DOM structure changes

Testing / Reviewing

  • Verify that the reported violation in [a11y]: Datatable - Selection story a11y violation  #14002 does not occur for the DataTable Selection variant through the v10 storybook using the IBM a11y checker scan (09 August 2023 latest version deployment).
  • No new violations introduced, no style or functional regressions
  • VO now announces the action of the checkbox (Select row, Unselect row, Select all rows, Unselect all rows)

@kenneth-nguyen1 kenneth-nguyen1 requested a review from a team as a code owner August 14, 2023 22:42
@kenneth-nguyen1 kenneth-nguyen1 requested review from tay1orjones and andreancardona and removed request for a team August 14, 2023 22:42
tay1orjones
tay1orjones approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate this, thanks! 🙌

@tay1orjones tay1orjones merged commit c200676 into carbon-design-system:v10 Aug 16, 2023
@pnayek pnayek mentioned this pull request Mar 27, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona andreancardona was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenneth-nguyen1 @alisonjoseph @tay1orjones