Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Notifications): add AVT tests #14409

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Aug 7, 2023

Closes #14329

Changelog

New

  • add AVT tests for all notification variants & keyboard

Changed

  • moved avt tests to new file

Testing / Reviewing

Ensure all tests pass

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit fac81f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64d1584bb42fad00087fe88a
😎 Deploy Preview https://deploy-preview-14409--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit fac81f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64d1584be101940008825360
😎 Deploy Preview https://deploy-preview-14409--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review August 7, 2023 20:47
@alisonjoseph alisonjoseph requested a review from a team as a code owner August 7, 2023 20:47
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tay1orjones tay1orjones added this pull request to the merge queue Aug 17, 2023
Merged via the queue into carbon-design-system:main with commit 90be2f6 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for Notification states: Hover/Active/Visited state
3 participants