Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typescript): add types for TableBatchActions #14390

Merged

Conversation

haocheng6
Copy link
Contributor

Closes #12520

Changelog

New

Changed

  • Update MultiSelect.tsx to reuse the new InternationalProps type.

Testing / Reviewing

  • CI should pass.
  • Existing stories of Data Table with batch actions should work the same as before.
  • At the bottom of TableBatchActions.tsx, add the following code snippet to verify that props can be passed to the component.
const x = (
  <TableBatchActions
    className="test"
    shouldShowBatchActions={true}
    totalSelected={1}
    onCancel={() => {}}>
    <div>Hello</div>
  </TableBatchActions>
);

@haocheng6 haocheng6 requested a review from a team as a code owner August 3, 2023 22:40
@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 676d5b8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e77b6c5ad3400008a7fd1e
😎 Deploy Preview https://deploy-preview-14390--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 676d5b8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e77b6b53611c00087af239
😎 Deploy Preview https://deploy-preview-14390--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you so much for the contribution @haocheng6 !

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@github-actions github-actions bot added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 24, 2023
@tw15egan tw15egan force-pushed the 12520-table-batch-actions-type branch from 377c6e6 to ac245c6 Compare August 24, 2023 15:40
@tw15egan
Copy link
Collaborator

@tay1orjones @haocheng6 @andreancardona pushed up some changes to fix the merge conflict, as well as made the select all button in the batch actions story function properly (that was added in the conflicting PR)

@tw15egan tw15egan added this pull request to the merge queue Aug 24, 2023
Merged via the queue into carbon-design-system:main with commit 95d40f7 Aug 24, 2023
14 checks passed
@haocheng6 haocheng6 deleted the 12520-table-batch-actions-type branch August 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to TableBatchActions
4 participants