-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(typescript): add types for TableBatchActions #14390
refactor(typescript): add types for TableBatchActions #14390
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thank you so much for the contribution @haocheng6 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
377c6e6
to
ac245c6
Compare
@tay1orjones @haocheng6 @andreancardona pushed up some changes to fix the merge conflict, as well as made the |
95d40f7
Closes #12520
Changelog
New
TableBatchActions
. Most of the new types are based on the legacy types in DefinitelyTyped.InternationalProps
from DefinitelyTyped/types/carbon-components-react/typings/shared.d.ts. This type can be reused by components with i18n support.Changed
MultiSelect.tsx
to reuse the newInternationalProps
type.Testing / Reviewing
TableBatchActions.tsx
, add the following code snippet to verify that props can be passed to the component.