fix(ListBox): backport listbox a11y fixes to v10 #14092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
changed the title
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
requested review from
alisonjoseph and
francinelucca
and removed request for
a team
tw15egan
added
version: 10
francinelucca
approved these changes
Jun 28, 2023
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
alisonjoseph
approved these changes
Jun 29, 2023
francinelucca
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14069
Refs #13173
Backports a11y fixes to v10
Changelog
Changed
xno longer receives focus (Multiselectselection, clear text fromComboBox+FilterableMultiselect, items can be cleared viaesckey. Can still click to activate.Multiselectso that the selection tag/button is not a descendant of another buttonTesting / Reviewing
Check
ComboBox,Multiselect, andFilterableMultiselectand ensure all functionality matches v11, and there are not a11y violations