Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(modal): add keyboard navigation e2e tests #14059

Conversation

tay1orjones
Copy link
Member

Part of #13747

Thanks for pairing up on this @andreancardona!

Changelog

New

  • Broke @avt tests out into their own Modal-test.avt.e2e.js file
    • @vrt tests remain in the Modal-test.e2e.js file
  • Add keyboard navigation tests covering flows for default, danger, and passive modals

Changed

Testing / Reviewing

  • CI should pass
  • Ensure the tests pass a sniff test and don't look problematic

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit b80318e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64a6c8adb4361200088ceaab
😎 Deploy Preview https://deploy-preview-14059--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b80318e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64a6c8ad2031d60007b46980
😎 Deploy Preview https://deploy-preview-14059--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@francinelucca
Copy link
Collaborator

looks like some extra configurations might be needed here @tay1orjones @andreancardona ? VRT CI is saying no tests found

@andreancardona
Copy link
Contributor

looks like some extra configurations might be needed here @tay1orjones @andreancardona ? VRT CI is saying no tests found

will look into now :)

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

e2e/components/Modal/Modal-test.avt.e2e.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kodiakhq kodiakhq bot merged commit 0fb4836 into carbon-design-system:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants