-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(modal): add keyboard navigation e2e tests #14059
test(modal): add keyboard navigation e2e tests #14059
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
looks like some extra configurations might be needed here @tay1orjones @andreancardona ? VRT CI is saying no tests found |
will look into now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Part of #13747
Thanks for pairing up on this @andreancardona!
Changelog
New
@avt
tests out into their ownModal-test.avt.e2e.js
file@vrt
tests remain in theModal-test.e2e.js
fileChanged
avt.e2e.js
)Testing / Reviewing