Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RadioButton): remove aria-readonly from fieldset #13936

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Jun 6, 2023

Closes #13665

Removes aria-readonly from the underlying fieldset in RadioButtonGroup

Changelog

Removed

  • Removed aria-readonly from fieldset

Testing / Reviewing

Ensure no a11y violations appear when readOnly is set to true in Radio Button story.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ce79499
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/647f937d6dbcaa000942b12f
😎 Deploy Preview https://deploy-preview-13936--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ce79499
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/647f937d5a79460008edecad
😎 Deploy Preview https://deploy-preview-13936--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed can no linger see violation

@kodiakhq kodiakhq bot merged commit d1ce510 into carbon-design-system:main Jun 6, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.31.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: RadioButtonGroup has invalid aria-readonly attribute
4 participants