Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added types to Link component #13754

Merged
merged 8 commits into from
Jun 7, 2023

Conversation

SunnyJohal
Copy link
Contributor

@SunnyJohal SunnyJohal commented May 7, 2023

Closes #13561

Added typescript types to Link component.

Changelog

New

  • Added typescript types to Link component.

Changed

  • File extensions from .js to .tsx

Removed

  • n/a

Testing / Reviewing

  • Run storybook, navigate to link component and check that it is still rendering.
  • Run unit tests

@SunnyJohal SunnyJohal requested a review from a team as a code owner May 7, 2023 17:46
@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d244f8d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6480966b58975f0008a9d984
😎 Deploy Preview https://deploy-preview-13754--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d244f8d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6480966badf8eb0008febea1
😎 Deploy Preview https://deploy-preview-13754--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one small change needed

packages/react/src/components/Link/Link.tsx Show resolved Hide resolved
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this - looks good!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


2 out of 3 committers have signed the DCO.
@andreancardona
@SunnyJohal
❌ @Sunny.Johal
Sunny.Johal seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@kodiakhq kodiakhq bot merged commit 0754f9c into carbon-design-system:main Jun 7, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.31.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to Link
4 participants