-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Storybook): Enable "buildStoriesJson" to support composition #13506 #13627
feat(Storybook): Enable "buildStoriesJson" to support composition #13506 #13627
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I have validated that the storybook build now includes a
Could somebody look into this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kubijo The production storybook is served via GitHub Pages, which has a Access-Control-Allow-Origin
header of *
. So it should work there.
I added a commit to this PR to update the Netlify config to specify the same for that header. I'm not sure if it'll work on the deploy preview yet. It might need to be merged into main
for it to take effect.
In either case you should be good to go 👍 Thanks for the PR!
Based on change already delivered to main branch for v11 in carbon-design-system#13627
Based on change already delivered to main branch for v11 in carbon-design-system#13627
Based on change already delivered to main branch for v11 in #13627
Closes #13506
Enable the
buildStoriesJson
storybook flag so that CDS storybook can be composedChangelog
New
buildStoriesJson
flag