Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storybook): Enable "buildStoriesJson" to support composition #13506 #13627

Merged

Conversation

kubijo
Copy link
Contributor

@kubijo kubijo commented Apr 19, 2023

Closes #13506

Enable the buildStoriesJson storybook flag so that CDS storybook can be composed

Changelog

New

  • storybook: Enable the buildStoriesJson flag

@kubijo kubijo requested a review from a team as a code owner April 19, 2023 11:39
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 61ac6fa
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64472d30a3a3820008776341
😎 Deploy Preview https://deploy-preview-13627--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 61ac6fa
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64472d30670c33000811995f
😎 Deploy Preview https://deploy-preview-13627--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kubijo
Copy link
Contributor Author

kubijo commented Apr 19, 2023

I have validated that the storybook build now includes a stories.json file; however, I'm getting a CORS error when trying to integrate it into our storybook instance:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://deploy-preview-13627--carbon-components-react.netlify.app/index.json. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 404.

Could somebody look into this?
I'm guessing that netlify will have some kind of settings for this kind of thing (not sure about your public production build, though)

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kubijo The production storybook is served via GitHub Pages, which has a Access-Control-Allow-Origin header of *. So it should work there.

I added a commit to this PR to update the Netlify config to specify the same for that header. I'm not sure if it'll work on the deploy preview yet. It might need to be merged into main for it to take effect.

In either case you should be good to go 👍 Thanks for the PR!

@kodiakhq kodiakhq bot merged commit a16b91f into carbon-design-system:main Apr 25, 2023
@kubijo kubijo deleted the enable-storybook-composition branch June 7, 2023 18:07
AlanGreene added a commit to AlanGreene/carbon-design-system that referenced this pull request Jul 26, 2023
Based on change already delivered to main branch for v11 in carbon-design-system#13627
AlanGreene added a commit to AlanGreene/carbon-design-system that referenced this pull request Jul 26, 2023
Based on change already delivered to main branch for v11 in carbon-design-system#13627
kodiakhq bot pushed a commit that referenced this pull request Jul 26, 2023
Based on change already delivered to main branch for v11 in #13627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Storybook composition support
4 participants