fix(toggle): ensure onToggle still work with props['aria-labelledby'] #13057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13004
Changelog
New
props['aria-labelledby']
is passed the wrapper element listens for aclick
event to triggerhandleClick
as the labeling element is no longer a<label>
but a<div>
and the<button>
is visually hidden.Changed
props.hideLabel
andprops.labelText
in the prop description ofprops.hideLabel
Testing / Reviewing
props.onClick
andprops.onToggle
function and verify that they are triggered both by clicking on the toggle and by using the keyboard whenprops['aria-labelledby']
is passed.props['aria-labelledby']
is not passed.