Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(light): change token used in Listbox, Tile, Select components #12984

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

tw15egan
Copy link
Collaborator

Closes #12956

Some components were updated to use the new $field and $layer tokens when using the light prop. This reverts this change so that the light style blocks refer to the v10 tokens i.e. $field-02 and $layer-02

Changelog

Changed

  • Changed from v11 tokens to v10 tokens under light style blocks

Testing / Reviewing

Try adding a light prop to ComboBox, Dropdown, MultiSelect, Select and Tile

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a65d02e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63c86e8cb6911700088179cb
😎 Deploy Preview https://deploy-preview-12984--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a65d02e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63c86e8cb6911700088179cd
😎 Deploy Preview https://deploy-preview-12984--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit f4d0253 into carbon-design-system:main Jan 18, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.21.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Light prop not working on dropdowns
4 participants