Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): update autoAlign to work when open is initially false #12938

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jan 9, 2023

Reported on slack, autoAlign was not working if the Popover was initially closed. Example

Changelog

Changed

  • add open to the useIsomorphicEffect dependency array housing the autoAlign logic

Testing / Reviewing

  • Go to the popover autoAlign story, I've added a new fifth popover at the bottom of the page that has local state.
  • Opening and closing this new stateful popover should show the popover being automatically aligned properly and not cut off by the bottom of the browser window.

@tay1orjones tay1orjones requested a review from a team as a code owner January 9, 2023 16:31
@tay1orjones tay1orjones self-assigned this Jan 9, 2023
@tay1orjones tay1orjones added type: bug 🐛 severity: 2 https://ibm.biz/carbon-severity labels Jan 9, 2023
@tay1orjones tay1orjones added this to the 2023 Q1 milestone Jan 9, 2023
@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 74f032a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63c8755b2763170008e4e3b8
😎 Deploy Preview https://deploy-preview-12938--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 74f032a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63c8755bda9ab80008840877
😎 Deploy Preview https://deploy-preview-12938--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in the test story 👍 ✅

@kodiakhq kodiakhq bot merged commit b568e8a into carbon-design-system:main Jan 18, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.21.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants