Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-tabs): fix tooltip styles icon only tab #12658

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

aledavila
Copy link
Contributor

Closes #12463

Makes tootip on Icon tab list visible
As the issue states the issue stems from the overflow-x: auto on the tab-list. Its necessary for scrolling the tab list when its longer than the container its in. The solution here is only based on the assumption that because icons are small there wouldn't be an instance where they are longer than the container so i removed it from icon only tab lists. I tried many other solutions that weren't working including z-index but it doesn't work. If this doesn't feel like the correct solution I'm also open to suggestions

Testing / Reviewing

Make sure theres no regressions

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f13a4a2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63763d8aaa7e920008b82e96
😎 Deploy Preview https://deploy-preview-12658--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f13a4a2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63763d8a94b04d0007f749cc
😎 Deploy Preview https://deploy-preview-12658--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a ton of icon tabs that need to be scrollable is far more of an edge case than having the tooltip visible for a single tab.

I agree we should prioritize the tooltips over the scrolling functionality if the two are incompatible.

@kodiakhq kodiakhq bot merged commit daf85f7 into carbon-design-system:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: IconTab tooltip is not visible
3 participants