Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(skeleton): add storybook playground story and cleanup #12450

Merged
merged 2 commits into from
Nov 9, 2022
Merged

chore(skeleton): add storybook playground story and cleanup #12450

merged 2 commits into from
Nov 9, 2022

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Nov 1, 2022

Closes #12448

Changelog

New

  • add default preview to mdx for SkeletonPlaceholder and SkeletonText
  • add playground story for SkeletonText

Changed

  • rename files -story to .stories

Removed

  • remove duplicate stories for SkeletonPlaceholder and SkeletonText
  • remove /next folder

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6bd99a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636be47e26033c000bd88821
😎 Deploy Preview https://deploy-preview-12450--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 1, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6bd99a4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636be47e8f127c0009bb9615
😎 Deploy Preview https://deploy-preview-12450--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alisonjoseph alisonjoseph marked this pull request as ready for review November 2, 2022 15:17
@alisonjoseph alisonjoseph requested a review from a team as a code owner November 2, 2022 15:17
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit e885af3 into carbon-design-system:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: components/Skeleton/next/Skeleton.stories.js
3 participants