Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(error-boundry): rename stories file #12232

Merged

Conversation

aledavila
Copy link
Contributor

Closes #12161

Rename Error Boundry story file to new file. No controls necessary.

Testing / Reviewing

Make sure stories are visible. No controls added

@aledavila aledavila requested a review from a team as a code owner October 4, 2022 20:50
@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 69b728f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/634830ef3c1fc40008cba14f
😎 Deploy Preview https://deploy-preview-12232--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 69b728f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/634830ef4c2f7e000922bb00
😎 Deploy Preview https://deploy-preview-12232--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in the new file name, should be ErrorBoundary-stories.js 🙂

@aledavila aledavila closed this Oct 5, 2022
@aledavila aledavila reopened this Oct 5, 2022
@aledavila
Copy link
Contributor Author

@abbeyhrt done !

@sstrubberg sstrubberg enabled auto-merge (squash) October 10, 2022 19:34
@sstrubberg sstrubberg merged commit 00158d0 into carbon-design-system:main Oct 13, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.15.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: provide ErrorBoundary playground, controls
5 participants