feat(react): first round of playground updates #12209
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks for doing this @TannerS, this is amazing and so helpful for us! It looks like we have an open PR for loading storybook controls, do you remind removing that one to avoid conflicts? |
|
@abbeyhrt can you point me in direction of what your referring too? Also anyway y'all can check on my questions :) |
| @@ -20,6 +20,44 @@ import { | |||
| import './FileUploader-story.scss'; | |||
|
|
|||
| const filenameStatuses = ['edit', 'complete', 'uploading']; | |||
| const argTypes = { | |||
There was a problem hiding this comment.
FileUploader is a bit tricky since it has such robust examples but I think we would still want it to follow the pattern of the other components in terms of controls, where only the "Playground" story has controls. To do so, if you don't already know, we would want to remove the passed in args from every story besides that one and only define the argtypes for Playground as well.
There was a problem hiding this comment.
@abbeyhrt can you explain this a bit more from every story besides that one and only define the argtypes for Playground as well.
There was a problem hiding this comment.
Hey tanner I actually have a PR with the correct playground story. We are cleaning up the stories to where only Playground stories will have the controls and Scott has a Loading PR already up for that as well. Also could you change the -story.js files to be .Stories.js so that they all match and are updated to the file type. And the files must be removed from the next folder and into the root Component file replacing the necessary files. the index files for those components will also need to be updated accordingly so that the Feature flag is removed since it is no longer necessary.
|
Closing to start over with new instructions and to prevent overlap with Loading story and file uploader story PRs |
Closes
Hopefully multiple sub issues in #10751
Side note: I had questions about these issues which i asked in a comment in #10751 which may affect/cause me to have to do changes in this pr. I have been having issues understanding what to keep, what to add and how to add it. So please take a look at those questions and let me know what I can fix/change in this PR
Changelog
New
Changed
Testing / Reviewing