Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loading): updated storybook controls, mdx, default props and tests #12206

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Sep 30, 2022

Closes #12162

Updated Storybook Controls and MDX. Also went in and moved the defaultProps to default params and updated the public API snapshot for fun-sies.

Changelog

Changed

  • Renamed .story -> .stories
  • Removed the knobs, moved to controls
  • Updated the MDX to show the goods
  • In the component itself moved the defaultProps to default params
  • Updated the Public API snapshot to reflect the new defaults params.

Testing / Reviewing

Hit up the Loading component in Storybook. Controls should work as expected. The docs tab should show the MDX.

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5f018ff
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/633ca108e3082400088c4ce8
😎 Deploy Preview https://deploy-preview-12206--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5f018ff
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/633ca108dd93780008c8ead8
😎 Deploy Preview https://deploy-preview-12206--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sstrubberg sstrubberg changed the title fix(loading): updated storybook controls, mdx, default props and tests [Storybook]: Loading component Sep 30, 2022
@sstrubberg sstrubberg changed the title [Storybook]: Loading component fix(loading): updated storybook controls, mdx, default props and tests Sep 30, 2022
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kodiakhq kodiakhq bot merged commit 7458ce3 into carbon-design-system:main Oct 4, 2022
@sstrubberg sstrubberg deleted the loading-story branch October 4, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: provide components/Loading/Loading-story.js playground, controls
3 participants