fix(v10): backport HCM fixes to v10 for RadioButton, Toggle, Notification #12100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
tay1orjones and
aledavila
and removed request for
a team
tw15egan
changed the title
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
requested review from
abbeyhrt
and removed request for
tay1orjones
abbeyhrt
approved these changes
Sep 16, 2022
aledavila
approved these changes
Sep 23, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11648
Closes #10458
Closes #10199
Refs #12098
Refs #12097
This backports a few V11 fixes that affected
RadioButton,ToggleandNotificationwhen using Windows HCMChangelog
Changed
RadioButton,ToggleandNotificationTesting / Reviewing
In Windows, enable a Dark High Contrast mode theme, and check out
RadioButton,ToggleandNotification. Also verify that the icons show up in a light theme (Desert if on Windows 11). Make sure the components are completely visible and no elements are missing