Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Toggle): fix issue with side label when hideLabel is true #12094

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

tw15egan
Copy link
Collaborator

Refs #6567

Fixes an issue I noticed when working on #6567

It seems like the voice-over issue no longer exists (🎉), but when hideLabel is set to true, the label is shown instead of the toggle text.

Screen Shot 2022-09-14 at 9 58 48 AM
Screen Shot 2022-09-14 at 9 58 43 AM

Changelog

Removed

  • Removed some extra code that was placing the label text incorrectly

Testing / Reviewing

Test with VoiceOver in Chrome / Safari and ensure the label and toggles are read correctly. In the playground story, enable hideLabel and test voice-over again. Ensure the correct labels are shown.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit db88831
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63223a8836df9d0008ac7469
😎 Deploy Preview https://deploy-preview-12094--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit db88831
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63223a8800146b000811f8c7
😎 Deploy Preview https://deploy-preview-12094--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VO is working for me for both stories 👍🏽

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq bot merged commit 89f51a3 into carbon-design-system:main Sep 14, 2022
tw15egan added a commit that referenced this pull request Dec 7, 2022
kodiakhq bot added a commit that referenced this pull request Dec 8, 2022
…#12094)" (#12810)

This reverts commit 89f51a3.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants