-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Toggle): fix issue with side label when hideLabel is true #12094
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VO is working for me for both stories 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Refs #6567
Fixes an issue I noticed when working on #6567
It seems like the voice-over issue no longer exists (🎉), but when
hideLabel
is set to true, the label is shown instead of the toggle text.Changelog
Removed
Testing / Reviewing
Test with VoiceOver in Chrome / Safari and ensure the label and toggles are read correctly. In the playground story, enable
hideLabel
and test voice-over again. Ensure the correct labels are shown.