Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add simple example of v10 and v11 being used together #12067

Merged
merged 6 commits into from
Sep 13, 2022

Conversation

abbeyhrt
Copy link
Contributor

@abbeyhrt abbeyhrt commented Sep 6, 2022

REF #11986
REF #12051

This PR adds a simple example of v10 and v11 working together. Most of the components are v10 but it uses the new Stack component and the v11 StructuredList. It's super simple but I wanted to get something up quick that we could build on/add to

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

Pull down PR and yarn and yarn dev the /incremental-migration example, make sure it all looks okay.

@abbeyhrt abbeyhrt requested a review from a team as a code owner September 6, 2022 19:10
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 4c6d6f9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/631f73a555419b0008f87aaa
😎 Deploy Preview https://deploy-preview-12067--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4c6d6f9
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/631f73a5e895700008324f90
😎 Deploy Preview https://deploy-preview-12067--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just commented some typo fixes :)


## Incremental migration

We ave recently released a new version, v11, of our component library and a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We ave recently released a new version, v11, of our component library and a
We have recently released a new version, v11, of our component library and a

common question we receive is if users can adopt v11 incrementally and the
answer is yes! If the burden of migrating to v11 is too big to take on all at
once, but there are features of our latest release you want to take advantage
of, it is likely that you can pull in just the parts yiu are wanting to use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of, it is likely that you can pull in just the parts yiu are wanting to use
of, it is likely that you can pull in just the parts you are wanting to use

common question we receive is if users can adopt v11 incrementally and the
answer is yes! If the burden of migrating to v11 is too big to take on all at
once, but there are features of our latest release you want to take advantage
of, it is likely that you can pull in just the parts yiu are wanting to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of, it is likely that you can pull in just the parts yiu are wanting to use
of, it is likely that you can pull in just the parts you are wanting to use

@kodiakhq kodiakhq bot merged commit e2ec828 into carbon-design-system:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants