Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): update v10 token styles #11977

Merged
merged 11 commits into from
Aug 22, 2022
Merged

fix(type): update v10 token styles #11977

merged 11 commits into from
Aug 22, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Aug 18, 2022

Closes #11864

Changelog

  • updates type tokens for
    • $expressive-heading-04
    • $expressive-heading-05
    • $productive-heading-05
    • $display-03
    • $display-04

Testing / Reviewing

@jnm2377 jnm2377 requested a review from a team as a code owner August 18, 2022 23:08
@jnm2377 jnm2377 requested review from aledavila and abbeyhrt and removed request for a team August 18, 2022 23:08
@tay1orjones tay1orjones requested review from tay1orjones and removed request for abbeyhrt August 19, 2022 19:09
aagonzales
aagonzales requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one mix up.

✅ $expressive-heading-04
✅ $expressive-heading-05
❌ $productive-heading-05
✅ $display-03
✅ $display-04

packages/type/src/styles.js Outdated Show resolved Hide resolved
tay1orjones
tay1orjones approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass with updated snaps

@jnm2377 jnm2377 merged commit 03e97d9 into carbon-design-system:v10 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@aagonzales aagonzales aagonzales approved these changes

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnm2377 @tay1orjones @aagonzales