-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multiselect): listbox hidden when closed #11944
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I seem to be still seeing the issue when the Multiselect is open
|
@tw15egan @dakahn this is ready for re-review. I added a tab index of -1 to the listbox menu item component bc the same accessibility error was present in Dropdown which also uses this component. ComboBox uses it as well, however, we added tabIndex -1 to that component so it wasn't failing a11y checker. So this change just adds it to all menu items by default. The components should all still work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not seeing the violation anymore, nice work 🔥
Closes #11341
Changelog
Testing / Reviewing
go to multiselect storybook and run the a11y checker on the closed menu
ensure all tests are passing and component is working as expected