Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiselect): fix warn icon on inline #11876

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

aledavila
Copy link
Contributor

Closes #11727

Fixes warn label on inline multiselect

Changelog

Changed

  • warning icon on multiselect

Testing / Reviewing

Make sure multiselect is working fine on both inline and normal

To test go to controls and turn on inline for type and true for warn props

@aledavila aledavila requested a review from a team as a code owner July 28, 2022 17:28
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for carbon-components-react failed.

Name Link
🔨 Latest commit 6a20132
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62e2c7442a66830008a7ab5e

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 3d152ea
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62e73d979914120008539037
😎 Deploy Preview https://deploy-preview-11876--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6a20132
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62e2c74452a5b80008cdd1f5
😎 Deploy Preview https://deploy-preview-11876--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 3d152ea
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62e73d971e42a80009f62608
😎 Deploy Preview https://deploy-preview-11876--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit f797002 into carbon-design-system:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Spacing issue between icon and text on warn inline multiselect
3 participants