refactor(react): update OverflowMenu and OverflowMenuItem tests to use RTL #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Jul 27, 2022
Comment on lines
+97
to
+99
| expect(container.firstChild).toHaveClass( | ||
| 'cds--overflow-menu-options__option--disabled' | ||
| ); |
There was a problem hiding this comment.
Minor expansion on the coverage here since it also disables the child of the li
Suggested change
| expect(container.firstChild).toHaveClass( | |
| 'cds--overflow-menu-options__option--disabled' | |
| ); | |
| expect(container.firstChild).toHaveClass( | |
| 'cds--overflow-menu-options__option--disabled' | |
| ); | |
| expect(container.firstChild.firstChild).toHaveProperty('disabled', true); |
There was a problem hiding this comment.
Good suggestion! Added :)
|
@abbeyhrt I'll let you add the merge label in case you want to take further action on Taylor's suggestion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11730
Closes #11732
This PR updates
OverflowMenuandOverflowMenuItemtests to use RTL.Changelog
New
Changed
Removed
Testing / Reviewing
Verify that tests pass and that the component API is properly tested.